ci: add zizmor static analysis for the workflows#1016
Merged
Conversation
Runs zizmor over .github/workflows and publishes results to the Security tab via SARIF. Report-only for now (continue-on-error) since the existing workflows still have findings to clear; a follow-up fixes those and turns this into a hard gate. Answers the "do we have zizmor setup" question from the review on jupyterlab#996. Based this on jupyterlab's own zizmor workflow and put it together with Claude Code, running zizmor against our workflows locally to confirm it works.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
krassowski
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds zizmor static analysis over the GitHub Actions workflows, based on the one JupyterLab core runs. This answers the "do we have zizmor setup" question from the review on #996.
It's report-only for now: the existing workflows still have a handful of findings (a couple of unscoped app-token permissions, some checkouts missing
persist-credentials: false, one template-injection), so instead of failing the build it uploads results to the Security tab via SARIF. A follow-up PR fixes those findings and flips this to a hard gate.Runs offline (no token passed), so it skips the online-only audits and avoids the API rate limits the zizmor docs warn about.
Put this together with Claude Code, using JupyterLab's zizmor workflow as the base and running zizmor against our workflows locally to confirm it works.